refactor universal: drop obsolete and inconsistent memory_order parameters in RateCounter#1224
Open
ddvamp wants to merge 1 commit intouserver-framework:developfrom
Open
refactor universal: drop obsolete and inconsistent memory_order parameters in RateCounter#1224ddvamp wants to merge 1 commit intouserver-framework:developfrom
ddvamp wants to merge 1 commit intouserver-framework:developfrom
Conversation
…eter in RateCounter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
userver/universal/include/userver/utils/statistics/rate_counter.hpp
Line 48 in 5bcfaae
userver/universal/include/userver/utils/statistics/rate_counter.hpp
Line 54 in 5bcfaae
These parameters were added in this commit, and then turned out to be unnecessary in this one.
Since they are no longer in use and their presence contradicts the class description, they should be deleted.